Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement forked collector for RFC4 #742

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Implement forked collector for RFC4 #742

wants to merge 5 commits into from

Conversation

sanchda
Copy link
Contributor

@sanchda sanchda commented Nov 15, 2024

What does this PR do?

This makes several changes to the implementation of crashtracking

  • Completely changes the sigaction guard sequence. It is no longer necessary to suppress so many signals, since the watchdog process can no longer write() to a closed file descriptor (SIGPIPE) and it tries really hard to consume the exit status of all of its children (SIGCHLD).
  • Spawns a collector process, which isolates non-async-signal-safe operations
  • Carefully manages the duration of each child process from the watchdog (better hang)
  • Migrate certain operations from the nix to libc crates in order to prevent panics

Motivation

RFC4 is a comprehensive improvement of the crashtracking implementation.

@sanchda
Copy link
Contributor Author

sanchda commented Nov 15, 2024

Still in draft form while I do some manual testing.

@pr-commenter
Copy link

pr-commenter bot commented Nov 15, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-11-15 15:00:10

Comparing candidate commit fe8a73e in PR branch sanchda/forked_collector with baseline commit d04fad9 in branch main.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 47 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/37828224631000521389798

  • 🟥 execution_time [+9.733µs; +9.807µs] or [+16.526%; +16.652%]
  • 🟥 throughput [-2423470.020op/s; -2407800.458op/s] or [-14.273%; -14.181%]

scenario:credit_card/is_card_number_no_luhn/37828224631000521389798

  • 🟥 execution_time [+9.644µs; +9.691µs] or [+16.375%; +16.455%]
  • 🟥 throughput [-2399084.626op/s; -2388965.615op/s] or [-14.130%; -14.070%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fe8a73e 1731682155 sanchda/forked_collector
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.599µs 4.613µs ± 0.009µs 4.613µs ± 0.006µs 4.618µs 4.629µs 4.634µs 4.636µs 0.50% 0.386 -0.440 0.19% 0.001µs 1 200
credit_card/is_card_number/ throughput 215698408.874op/s 216778241.305op/s ± 406865.587op/s 216775939.386op/s ± 275912.358op/s 217088166.596op/s 217371656.280op/s 217402039.801op/s 217419131.661op/s 0.30% -0.378 -0.451 0.19% 28769.742op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 93.224µs 93.533µs ± 0.348µs 93.488µs ± 0.120µs 93.612µs 93.762µs 94.429µs 97.718µs 4.52% 8.951 103.018 0.37% 0.025µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10233535.007op/s 10691533.832op/s ± 38542.293op/s 10696537.531op/s ± 13725.579op/s 10709383.835op/s 10717306.414op/s 10724706.195op/s 10726843.927op/s 0.28% -8.677 98.447 0.36% 2725.352op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 85.236µs 85.389µs ± 0.334µs 85.333µs ± 0.028µs 85.359µs 85.664µs 86.556µs 89.425µs 4.80% 9.520 107.046 0.39% 0.024µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11182511.765op/s 11711262.283op/s ± 44139.358op/s 11718749.224op/s ± 3790.577op/s 11722629.184op/s 11726910.509op/s 11729772.247op/s 11732070.141op/s 0.11% -9.308 103.064 0.38% 3121.124op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.591µs 4.612µs ± 0.009µs 4.612µs ± 0.006µs 4.618µs 4.627µs 4.632µs 4.663µs 1.11% 1.108 4.527 0.19% 0.001µs 1 200
credit_card/is_card_number/37828224631 throughput 214447616.867op/s 216809148.936op/s ± 409033.047op/s 216837621.339op/s ± 290676.654op/s 217119137.995op/s 217376212.189op/s 217400327.089op/s 217836006.262op/s 0.46% -1.079 4.341 0.19% 28923.004op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 81.608µs 82.056µs ± 0.191µs 82.042µs ± 0.086µs 82.123µs 82.297µs 82.726µs 83.299µs 1.53% 2.344 10.937 0.23% 0.013µs 1 200
credit_card/is_card_number/378282246310005 throughput 12004982.658op/s 12186904.709op/s ± 28180.747op/s 12188869.127op/s ± 12801.189op/s 12202640.651op/s 12220818.900op/s 12241882.161op/s 12253753.541op/s 0.53% -2.293 10.589 0.23% 1992.680op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 68.446µs 68.666µs ± 0.267µs 68.525µs ± 0.060µs 68.730µs 69.281µs 69.375µs 69.430µs 1.32% 1.530 1.100 0.39% 0.019µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 14403041.291op/s 14563429.858op/s ± 56216.982op/s 14593214.886op/s ± 12769.187op/s 14602657.684op/s 14606444.656op/s 14607555.831op/s 14610072.184op/s 0.12% -1.521 1.074 0.39% 3975.141op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.819µs 6.831µs ± 0.023µs 6.823µs ± 0.003µs 6.825µs 6.894µs 6.909µs 6.934µs 1.63% 2.761 6.815 0.33% 0.002µs 1 200
credit_card/is_card_number/x371413321323331 throughput 144208176.199op/s 146392841.230op/s ± 477891.505op/s 146552686.594op/s ± 55118.862op/s 146611306.933op/s 146630786.585op/s 146645626.142op/s 146651217.933op/s 0.07% -2.749 6.735 0.33% 33792.032op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.591µs 4.613µs ± 0.008µs 4.613µs ± 0.006µs 4.619µs 4.629µs 4.631µs 4.639µs 0.56% 0.331 -0.377 0.18% 0.001µs 1 200
credit_card/is_card_number_no_luhn/ throughput 215561405.719op/s 216776326.205op/s ± 397923.275op/s 216773759.642op/s ± 291436.622op/s 217077968.341op/s 217358977.739op/s 217387853.931op/s 217795805.984op/s 0.47% -0.323 -0.385 0.18% 28137.425op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 73.396µs 73.708µs ± 0.136µs 73.721µs ± 0.089µs 73.802µs 73.877µs 73.946µs 74.487µs 1.04% 0.593 4.228 0.18% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13425179.991op/s 13567065.917op/s ± 24935.173op/s 13564693.818op/s ± 16313.822op/s 13582278.862op/s 13609214.664op/s 13620558.149op/s 13624662.001op/s 0.44% -0.562 4.048 0.18% 1763.183op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 65.272µs 65.450µs ± 0.130µs 65.442µs ± 0.110µs 65.537µs 65.704µs 65.749µs 65.772µs 0.50% 0.424 -0.706 0.20% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15204086.540op/s 15278901.174op/s ± 30339.166op/s 15280591.364op/s ± 25808.131op/s 15308903.275op/s 15317651.909op/s 15319764.427op/s 15320426.725op/s 0.26% -0.418 -0.717 0.20% 2145.303op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.588µs 4.613µs ± 0.009µs 4.613µs ± 0.007µs 4.619µs 4.629µs 4.631µs 4.634µs 0.46% 0.179 -0.566 0.19% 0.001µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 215777611.178op/s 216773778.736op/s ± 415827.845op/s 216780954.997op/s ± 311944.788op/s 217121274.089op/s 217378985.906op/s 217407750.149op/s 217937031.571op/s 0.53% -0.171 -0.568 0.19% 29403.469op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.128µs 62.509µs ± 0.143µs 62.504µs ± 0.072µs 62.583µs 62.743µs 62.903µs 63.044µs 0.86% 0.306 1.245 0.23% 0.010µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15861951.759op/s 15997786.421op/s ± 36577.741op/s 15998925.190op/s ± 18363.817op/s 16012822.989op/s 16056564.109op/s 16080754.406op/s 16095885.892op/s 0.61% -0.284 1.219 0.23% 2586.437op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 68.455µs 68.563µs ± 0.169µs 68.501µs ± 0.033µs 68.575µs 68.876µs 69.308µs 69.350µs 1.24% 2.881 8.828 0.25% 0.012µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 14419577.915op/s 14585174.859op/s ± 35724.667op/s 14598389.798op/s ± 7134.011op/s 14604972.628op/s 14607164.157op/s 14607687.266op/s 14608182.043op/s 0.07% -2.862 8.709 0.24% 2526.115op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.819µs 6.833µs ± 0.026µs 6.824µs ± 0.003µs 6.826µs 6.885µs 6.948µs 7.015µs 2.81% 3.436 14.977 0.39% 0.002µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 142549282.682op/s 146347462.860op/s ± 558880.524op/s 146549952.322op/s ± 56654.137op/s 146605709.065op/s 146631164.796op/s 146643058.694op/s 146647184.640op/s 0.07% -3.378 14.386 0.38% 39518.821op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.612µs; 4.614µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number/ throughput [216721853.647op/s; 216834628.962op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [93.485µs; 93.581µs] or [-0.052%; +0.052%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10686192.241op/s; 10696875.423op/s] or [-0.050%; +0.050%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [85.343µs; 85.435µs] or [-0.054%; +0.054%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11705144.993op/s; 11717379.574op/s] or [-0.052%; +0.052%] None None None
credit_card/is_card_number/37828224631 execution_time [4.611µs; 4.614µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number/37828224631 throughput [216752460.890op/s; 216865836.983op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number/378282246310005 execution_time [82.029µs; 82.082µs] or [-0.032%; +0.032%] None None None
credit_card/is_card_number/378282246310005 throughput [12182999.129op/s; 12190810.290op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [68.629µs; 68.703µs] or [-0.054%; +0.054%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [14555638.725op/s; 14571220.991op/s] or [-0.053%; +0.053%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.828µs; 6.834µs] or [-0.046%; +0.046%] None None None
credit_card/is_card_number/x371413321323331 throughput [146326610.063op/s; 146459072.396op/s] or [-0.045%; +0.045%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.612µs; 4.614µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ throughput [216721177.867op/s; 216831474.544op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [73.689µs; 73.727µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13563610.142op/s; 13570521.692op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [65.432µs; 65.468µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15274696.457op/s; 15283105.890op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.612µs; 4.614µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [216716148.996op/s; 216831408.476op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [62.489µs; 62.529µs] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15992717.098op/s; 16002855.744op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [68.540µs; 68.587µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [14580223.764op/s; 14590125.954op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.829µs; 6.837µs] or [-0.054%; +0.054%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146270007.395op/s; 146424918.326op/s] or [-0.053%; +0.053%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fe8a73e 1731682155 sanchda/forked_collector
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 271.834µs 273.441µs ± 0.839µs 273.364µs ± 0.605µs 273.979µs 274.897µs 275.344µs 276.015µs 0.97% 0.364 -0.175 0.31% 0.059µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3622990.629op/s 3657127.673op/s ± 11203.627op/s 3658129.508op/s ± 8107.292op/s 3666156.043op/s 3674034.137op/s 3678009.683op/s 3678710.274op/s 0.56% -0.348 -0.195 0.31% 792.216op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 25.793µs 25.937µs ± 0.157µs 25.869µs ± 0.046µs 25.953µs 26.287µs 26.350µs 26.436µs 2.19% 1.524 0.988 0.60% 0.011µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 37826563.439op/s 38555688.038op/s ± 231615.863op/s 38656628.021op/s ± 68196.095op/s 38708426.478op/s 38739669.655op/s 38762732.704op/s 38770138.732op/s 0.29% -1.512 0.951 0.60% 16377.715op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.465µs 15.631µs ± 0.084µs 15.643µs ± 0.055µs 15.686µs 15.763µs 15.818µs 15.834µs 1.22% -0.101 -0.490 0.53% 0.006µs 1 200
normalization/normalize_name/normalize_name/good throughput 63154637.287op/s 63978267.788op/s ± 342612.219op/s 63926816.606op/s ± 225305.205op/s 64244041.700op/s 64571877.824op/s 64619557.302op/s 64661408.616op/s 1.15% 0.124 -0.503 0.53% 24226.342op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [273.325µs; 273.557µs] or [-0.043%; +0.043%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3655574.958op/s; 3658680.388op/s] or [-0.042%; +0.042%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [25.916µs; 25.959µs] or [-0.084%; +0.084%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [38523588.307op/s; 38587787.769op/s] or [-0.083%; +0.083%] None None None
normalization/normalize_name/normalize_name/good execution_time [15.619µs; 15.642µs] or [-0.074%; +0.074%] None None None
normalization/normalize_name/normalize_name/good throughput [63930785.029op/s; 64025750.546op/s] or [-0.074%; +0.074%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fe8a73e 1731682155 sanchda/forked_collector
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.528µs 38.092µs ± 0.884µs 37.707µs ± 0.106µs 37.827µs 39.959µs 39.995µs 41.334µs 9.62% 1.734 1.279 2.31% 0.062µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.969µs; 38.214µs] or [-0.321%; +0.321%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fe8a73e 1731682155 sanchda/forked_collector
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 293.806ns 308.048ns ± 15.555ns 300.524ns ± 5.676ns 323.104ns 339.647ns 348.726ns 351.493ns 16.96% 1.051 -0.117 5.04% 1.100ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [305.892ns; 310.204ns] or [-0.700%; +0.700%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fe8a73e 1731682155 sanchda/forked_collector
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.017ms 9.055ms ± 0.027ms 9.053ms ± 0.008ms 9.061ms 9.077ms 9.118ms 9.323ms 2.98% 6.610 57.299 0.30% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.051ms; 9.059ms] or [-0.042%; +0.042%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fe8a73e 1731682155 sanchda/forked_collector
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.377µs 3.311µs ± 1.417µs 3.163µs ± 0.026µs 3.186µs 3.226µs 14.129µs 15.149µs 378.98% 7.558 57.394 42.71% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.114µs; 3.507µs] or [-5.934%; +5.934%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fe8a73e 1731682155 sanchda/forked_collector
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 506.576µs 507.667µs ± 0.403µs 507.646µs ± 0.209µs 507.855µs 508.285µs 508.806µs 509.890µs 0.44% 1.019 4.600 0.08% 0.028µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1961205.962op/s 1969796.338op/s ± 1561.546op/s 1969878.016op/s ± 809.755op/s 1970652.350op/s 1971907.807op/s 1973364.377op/s 1974035.626op/s 0.21% -1.006 4.541 0.08% 110.418op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 468.146µs 468.874µs ± 0.308µs 468.878µs ± 0.219µs 469.088µs 469.326µs 469.645µs 470.023µs 0.24% 0.273 0.450 0.07% 0.022µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2127555.460op/s 2132769.205op/s ± 1400.241op/s 2132750.471op/s ± 996.743op/s 2133745.947op/s 2134986.259op/s 2135694.848op/s 2136086.231op/s 0.16% -0.268 0.442 0.07% 99.012op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 179.964µs 180.458µs ± 0.189µs 180.436µs ± 0.119µs 180.584µs 180.743µs 180.898µs 180.992µs 0.31% 0.109 0.170 0.10% 0.013µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5525091.936op/s 5541455.482op/s ± 5806.409op/s 5542116.299op/s ± 3644.933op/s 5544981.211op/s 5550550.096op/s 5554773.424op/s 5556651.827op/s 0.26% -0.102 0.168 0.10% 410.575op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.732µs 44.913µs ± 0.082µs 44.911µs ± 0.050µs 44.952µs 45.050µs 45.126µs 45.423µs 1.14% 1.434 6.815 0.18% 0.006µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22015464.224op/s 22265533.821op/s ± 40420.121op/s 22266353.118op/s ± 24582.131op/s 22291778.198op/s 22318371.852op/s 22344621.808op/s 22355552.215op/s 0.40% -1.397 6.572 0.18% 2858.134op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.052µs 49.146µs ± 0.072µs 49.135µs ± 0.055µs 49.196µs 49.268µs 49.325µs 49.381µs 0.50% 0.763 -0.263 0.15% 0.005µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20250800.204op/s 20347717.925op/s ± 29594.323op/s 20352091.177op/s ± 22774.318op/s 20374448.811op/s 20379822.101op/s 20383474.693op/s 20386504.134op/s 0.17% -0.758 -0.277 0.15% 2092.635op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [507.611µs; 507.723µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1969579.923op/s; 1970012.753op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [468.832µs; 468.917µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2132575.145op/s; 2132963.265op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [180.432µs; 180.484µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5540650.770op/s; 5542260.195op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [44.901µs; 44.924µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22259931.981op/s; 22271135.661op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.136µs; 49.156µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20343616.436op/s; 20351819.414op/s] or [-0.020%; +0.020%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fe8a73e 1731682155 sanchda/forked_collector
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 141.053µs 141.801µs ± 0.413µs 141.766µs ± 0.224µs 141.977µs 142.372µs 142.725µs 145.301µs 2.49% 3.203 24.255 0.29% 0.029µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [141.744µs; 141.859µs] or [-0.040%; +0.040%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fe8a73e 1731682155 sanchda/forked_collector
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.685µs 2.708µs ± 0.027µs 2.699µs ± 0.008µs 2.711µs 2.798µs 2.802µs 2.809µs 4.08% 2.514 5.716 1.00% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.704µs; 2.712µs] or [-0.139%; +0.139%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fe8a73e 1731682155 sanchda/forked_collector
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 58.237ms 58.525ms ± 0.242ms 58.504ms ± 0.097ms 58.584ms 58.791ms 59.576ms 60.012ms 2.58% 3.489 16.332 0.41% 0.017ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [58.491ms; 58.558ms] or [-0.057%; +0.057%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fe8a73e 1731682155 sanchda/forked_collector
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.933µs 27.149µs ± 11.206µs 19.166µs ± 0.990µs 36.211µs 37.029µs 44.563µs 99.437µs 418.82% 2.497 13.146 41.17% 0.792µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [25.595µs; 28.702µs] or [-5.721%; +5.721%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fe8a73e 1731682155 sanchda/forked_collector
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 69.287µs 69.500µs ± 0.160µs 69.488µs ± 0.049µs 69.533µs 69.644µs 69.957µs 71.277µs 2.58% 7.301 75.561 0.23% 0.011µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [69.477µs; 69.522µs] or [-0.032%; +0.032%] None None None

Baseline

Omitted due to size.

@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To override this behavior, add the keep-open label or update the PR.

@github-actions github-actions bot added the stale Used by actions/stale to identify PRs that have been inactive for 90+ days label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale Used by actions/stale to identify PRs that have been inactive for 90+ days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sanchda